Add FORCE_SQLITE Toggle to Avoid Database Conflicts #334
Conversation
|
@claude review this and propose a solution |
1 similar comment
|
@claude review this and propose a solution |
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
|
@claude review and if this issue is a valid issue fix it |
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
1 similar comment
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
There was a problem hiding this comment.
Pull Request Overview
This PR adds a FORCE_SQLITE toggle to the database configuration to avoid conflicts when using Supabase/Postgres in production, enhances logging, and provides an optional patch system with documentation updates.
- Introduces FORCE_SQLITE in db.py and its counterpart copy in codePatches.
- Adds detailed logging for connection decisions.
- Updates the README and .gitignore and provides a patch directory with supporting documentation.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| praisonai/ui/db.py | Adds FORCE_SQLITE toggle, conditional DB URL selection, and logging. |
| praisonai/ui/README.md | Updates documentation to explain the new toggle functionality. |
| codePatches/praisonai/ui/db.py | Provides a patched copy reflecting FORCE_SQLITE toggle usage. |
| codePatches/README | Documents instructions for applying the patch. |
| PraisonAI.code-workspace | Updates workspace configuration to include the patch directory. |
| # Without an option for toggling this on or off this easily causes conflicts, and is intrusive | ||
| # self.database_url = os.getenv("DATABASE_URL") | ||
| # supabase_url = os.getenv("SUPABASE_DATABASE_URL") | ||
| # if supabase_url: | ||
| # self.database_url = supabase_url |
There was a problem hiding this comment.
Consider removing the commented-out code block (lines 79-83) if it is no longer necessary to reduce clutter and improve maintainability.
| # Without an option for toggling this on or off this easily causes conflicts, and is intrusive | |
| # self.database_url = os.getenv("DATABASE_URL") | |
| # supabase_url = os.getenv("SUPABASE_DATABASE_URL") | |
| # if supabase_url: | |
| # self.database_url = supabase_url | |
| # (No replacement lines; the block is removed entirely.) |
Copilot uses AI. Check for mistakes.
| cd /path/to/venvPraison/lib/python3.11/site-packages/ | ||
|
|
||
| 1. codePatches/praisonai/ui/db.py | ||
| - fixes error where praisonAi tries to gain access to supabase or postgres isntance of production code. this is disallowed because of a table conflict in the [users] table where an either or relationship is caused by conflict schema between the two applications prismScape and praisonAi |
There was a problem hiding this comment.
Correct the spelling of 'isntance' to 'instance' in this line for clarity.
| - fixes error where praisonAi tries to gain access to supabase or postgres isntance of production code. this is disallowed because of a table conflict in the [users] table where an either or relationship is caused by conflict schema between the two applications prismScape and praisonAi | |
| - fixes error where praisonAi tries to gain access to supabase or postgres instance of production code. this is disallowed because of a table conflict in the [users] table where an either or relationship is caused by conflict schema between the two applications prismScape and praisonAi |
Copilot uses AI. Check for mistakes.
Description:
This pull request introduces a FORCE_SQLITE toggle to address database conflicts when using PraisonAI in environments where Supabase or PostgreSQL databases are active. Additionally, it includes a README update and an optional patch system for ease of use in similar situations.
Here’s a well-formatted description for your pull request:
Title:
Add FORCE_SQLITE Toggle to Avoid Database Conflicts
Description:
This pull request introduces a
FORCE_SQLITEtoggle to address database conflicts when usingPraisonAIin environments where Supabase or PostgreSQL databases are active. Additionally, it includes a README update and an optional patch system for ease of use in similar situations.Changes:
FORCE_SQLITEToggle indb.pyFORCE_SQLITE) has been added to thepraisonai/ui/db.pyfile.True,PraisonAIwill bypass the detection of Supabase/Postgres and exclusively use SQLite as the database backend.userstable definitions betweenPraisonAIand production applications.Enhanced Logging
Patch System Directory
codePatchesdirectory with a copy of the patcheddb.pyfor users who might need to apply similar fixes without editing the source directly.READMEfile to explain the purpose and usage of these patches.Updated
.gitignoreDocumentation
praisonai/ui/README.mdfile to include an explanation of theFORCE_SQLITEfeature and how to enable it.Why This Change Is Necessary:
PraisonAIand a production application share the same.envfile,PraisonAIprioritizes Supabase/Postgres connections over SQLite. This leads to schema conflicts, particularly with theuserstable.FORCE_SQLITEtoggle, users can explicitly directPraisonAIto use a local SQLite database, ensuring separation between production databases and the tool's data needs.How to Use:
FORCE_SQLITE = Trueinpraisonai/ui/db.py..envfile does not interfere with this behavior.PraisonAIas usual; it will now use SQLite exclusively.Notes for Maintainers:
FORCE_SQLITE) is desirable, I am happy to contribute a separate PR to introduce a centralized config system.FORCE_SQLITEtoggle in the primary documentation for broader user awareness.Testing:
Supabase+PraisonAI) and confirmed that enabling theFORCE_SQLITEtoggle successfully isolatedPraisonAIto SQLite.Let me know if there are any additional adjustments you'd like me to make! It is my opinion that this would be well suited for a centralized config file where the user can select whichever database they want used instead of having auto-detect, or in addition to having autodetect.
I love you work!